Subtle changes, bugs and feedback

This place is looking FRESH. That is all.

On Chrome / Windows the font selector also takes you to the search page.

Actually, all I'm trying to do is add ?fontsize= to the query string.

But if you are on a search page then you already have a query, and if you are on a POST'd result with a hash... then I need to know where to insert the fontsize=

I needed it to be cross-browser, one-line... so I figure that most font-resizing would happen on the home page or thread pages... less so on search results, so it'd be fine to do it the way I have.

A one-liner.

BTW, if anyone is on Linux then I highly recommend the Liberation Sans font as the browser default.

Crisp and clear at 100%, doesn't even feel too large. It's really nice.

I got nerged twice today... wtf?

You expected to please everyone?

It was probably the live programming, they weren't impressed.

Oh, just made another change... remove the "reply" and "unsubscribe" links from the thread subscriptions within the User CP.

I got nerged twice today... wtf?

It's those internets junkies...

Actually, all I'm trying to do is add ?fontsize= to the query string.

But if you are on a search page then you already have a query, and if you are on a POST'd result with a hash... then I need to know where to insert the fontsize=

I needed it to be cross-browser, one-line... so I figure that most font-resizing would happen on the home page or thread pages... less so on search results, so it'd be fine to do it the way I have.

A one-liner.

Just looked at that code. You're doing it in a very complicated way. Spans with onclicks that run a function that uses two string.replaces to remove the hash and query strings and append a "?fontsize=2" to the URL.
All you need is 4 A elements, and no JS.

Fun, eh? But did you see the jQuery hook attached to it?

The live update doesn't work in ie9.

This is not a new problem.

I might rip that apart soon.

It's been annoying me for quite a while. It's really shitty code.

Size of LFGSS code base:

PHP files: 2,060
Lines of PHP code: 356,258
HTML Templates in the database: 1,131
Regular expressions pulled out of the database and applied to every post: 238

This is one legacy beast.

Oh, just made another change... remove the "reply" and "unsubscribe" links from the thread subscriptions within the User CP.

Awesome, thanks :)

Heh,

mod_rewrite rules in apache.conf: 67
URL redirect (pretty URL) rules written into the PHP: 300+ (couldn't get a precise number)

Fun, eh? But did you see the jQuery hook attached to it?

Nope. how are you attaching it? You haven't got any obvious classnames or ids to hook into

Other strange things I saw
var vb_disable_ajax = parseInt("0", 10);

Why not just var vb_disable_ajax = 0; I wonder?

And you're including the Yahoo animation easing library. Are you doing any animation anywhere?

I'm not, vBulletin is.

Some of the menus slide out (like the page jump one just down and to the right from here).

And vBulletin also has some weird AJAX that isn't really AJAX.

Except for the admin stuff... that allows us to live edit most things inline.

I realise I could rip all that out... but you preached pragmatism earlier. I'm ignoring the weirder vBulletin stuff and just tip-toeing around that.

I don't understand why people make such a fuss about code when we don't even have very much of it on the forum. OK, there's UTFS, HTFU, BB, CSB, and so on, and I don't really see the point in re-writing any of it, either.

Change is good! Long Live Change!

I'm not, vBulletin is.

Some of the menus slide out (like the page jump one just down and to the right from here).

And vBulletin also has some weird AJAX that isn't really AJAX.

Except for the admin stuff... that allows us to live edit most things inline.

I realise I could rip all that out... but you preached pragmatism earlier. I'm ignoring the weirder vBulletin stuff and just tip-toeing around that.

Good approach. remove a little bit at a time, checking it still works and leave the engine intact until the templates are done. Then start on the engine :-)

I assume that everything that's left is what vBulletin adds after you turn everything off in whatever admin interface it gives you?

Most of the weight is HTML. If you want real improvement try redeveloping the single post template.

I tried, it doesn't work.

The post template is the same template that renders private messages and comments on member info pages.

They even have their own templating language.

That bit up above with 1,131 HTML templates... v3 was an experiment to see whether I could change a mere 150 or so to make a whole new site, and see whether the remainder would still work OK even if they were fugly.

But it didn't work. The templates are so horribly linked that to try and fix the major ones you have to do the lion's share of all 1,131 templates.

It's not going to happen, that's what a large legacy code base is. Which is why I get frustrated with you, you appear not to comprehend the size and complexity of a decade old codebase used to power 20,000 web-sites, that I then customised with the addition of at least 20k to 30k of my lines of PHP, and another hundred HTML templates.

What I've achieved today... live, without an exit plan if things went wrong (templates are in the database along with posts and real content which is why I did it live)... is about as good as it gets or I'm going to try.

13 minutes to midnight. Do you reckon you've got some time to fit in a feature that I think would be quite handy?

A keyword alert widget that can be used in classifieds. Basically, I think it would be quite handy if a user wants to find a certain part or brand for sale that comes up every so often to have an email alert if a classified is posted with that keyword. What do you think? Would it work?

On second thoughts it would probably involve quite a bit of work, so maybe you can add the feature tomorrow! ; )

Nope, but that's a damn good feature.

I'll note it for the future.

Don't forget the laundry, roboto.

Thanks for the reminder.