-
• #7302
How much effort is a dark mode through? Any white background website is horrifying.
-
• #7303
Just testing something
var test
^ was trying to see if the Markdown actually renders the lang attribute for code blocks. The answer is "no".
-
• #7304
Doesn't it? That's probably a bug... Prettifier not working out looking to remove it in the new?
Another forum on this is https://espruino.microcosm.app which does post code snippets.
-
• #7305
Let me share the original CSS building stuff later, you can adjust whatever you wish to make a dark theme. If it works for multiple sites then I'll make it available based on device setting (dark mode device would get dark mode site).
There switching is easy, making a decent dark mode CSS that works for different site branding is hard. If you've done a chunk of that then let's use that.
Edit: @snottyotter https://github.com/microcosm-cc/microweb-bootstrap that's what you need.
-
• #7306
I browsed a few, but I cannot see any code blocks with a
lang
attribute rendered. it's all<pre><code>
-
• #7307
Well I'm good to remove prettifier if we were never using it.
Probably a regression over something hospital, but removing it and adding something more sane in the future is wise.
-
• #7308
Oh no, that's not what I'm saying. I just think that the prettifier does the formatting in a language agnostic way.
There is a code path in the codebase that seems to deal with the lang attribute though, but I think it's dead.
https://github.com/buro9/microcosm/blob/main/web/server/static/js/base.js#L38-L46
-
• #7309
Yeah, there's nothing in the server side of this which would make that work from Markdown.
Edit: There's also no way at all to prettyprint with the correct language using HTML. The sanitizer nukes the class.
-
• #7310
Looks like I can remove that from the refactor then :)
-
• #7311
All beyond my skillset I'm afraid, there's a way to force it browser wide on Chrome for Android which is all I've been doing, doesn't work well for every site but a lot of my browsing is here where it does, although looked better before whatever Chrome changed that highlights all the dividing lines. I only really asked because I knew you were intending on doing some work and wondered if it was an unintended consequence for an edge use case.
-
• #7312
Tracking here: https://github.com/buro9/microcosm/issues/136
It's going to be a long wait... but it will come.
-
• #7313
The grand rewrite is being tracked here: https://www.lfgss.com/conversations/379635/
-
• #7314
.
edit: moving to the "grand rewrite" thread
-
• #7315
Minor bug but in iOS 16 Safari, the number input in the pagination captures focus on page load, so whenever you arrive at a forum list page the keyboard is launched.
1 Attachment
-
• #7316
There is nothing in the code that captures focus.
Safari has a bug.
Unsure how to report things to Apple 🤷
-
• #7317
Unsure how to report things to Apple 🤷
"Hey, Siri - there's a bug in Safari."
-
• #7318
I've submitted a bug to the webkit team which includes Apple engineers: https://bugs.webkit.org/show_bug.cgi?id=245123
This bug https://bugs.webkit.org/show_bug.cgi?id=195884 leads me to believe that they have changed things in this code, so I think they may actually look at the bug report I've filed.
-
• #7319
Is it consistent? Every page load of every page with a pagination control?
Basically... we've not been able to reproduce it. Would need more evidence... a video recording of it, debug messages, etc.
-
• #7320
I'll try to grab a video later... and not sure how to get the console up in iOS.
Happens on any page with the pagination (sub-forums and threads), in a normal tab and in a private browsing tab. With and without extensions enabled.
-
• #7321
https://www.replay.io/ looks quite cool for recording these kind of issues
Edit. Not sure it works on iOS though...
-
• #7322
You could always use another phone to film the phone... literal video screenshot. :)
-
• #7323
Sorry, the truth is my phone is in Spanish and I had to remember where the setting was to add screen recording back into control centre so I could record!
-
• #7324
It says "1 video" but when I click download it gives me "1 photo".
Could you email the video to email@david.kitchen and I shall put it somewhere the bug handlers can access.
-
• #7325
Done.
None of the browser options under chrome://flags for dodgy dark mode stuff gets rid of the previously also rendered dark lines and I can't do this bright shit. Lines it is.
1 Attachment