Subtle changes, bugs and feedback

Hah.

Well...

It's an array of files, but you don't have to provide them all at once in the "upload a file".

Originally (6+ years ago), you could select one, then select another, then another... up to 5 files.

And whilst the file upload did break altogether in FF... it also broke in Chrome and all browsers over time such that the array was no longer appendable, it was clobbered.

So the experience on mobile is still limited as not all mobiles offer multi-select by default, and that's what this solved by the website doing it :D

The drag and drop we purposefully disabled as that never played nice with mobile (hence the commented out lines)... but the array append did originally work.

I wondered why that was but didn't dare to change it. I can make that work ...

Is there still a max file count validation on the server?

Nope... the max 30MB is enforced, but "5 files total" is advisory as too many files per comment can lead to too many files on a page of 25 comments, which then results in a crappy slow loading page.

If someone does blow past the 5 files and they're large files, they're likely to hit the max_upload limit which is enforced and kicks in at 100MB of upload in a single go.

If you want me to I can try add up the file size total and individual file sizes with some better visual feedback? Especially if you can add to them after making the first selection?

Adding to them after the first selection will be the main goal.

Anything that adds to the experience beyond that is nice but not essential.

Don't go too crazy... because this stuff is crazier than you think, the file upload is still within the form and did actually degrade elegantly (though I've not tested that in a long while).

Hmm...

lol... now I'm JavaScript disabled :)

1 Attachment

Still degrades nicely

I can't delete attachments. FF89 on both Windows and Android

Just checked on FF Android.

Deleting already uploaded files works.

When multiple files are added i can delete all but the last one that hasn't been saved yet.

Is that in line with what you're getting?
Either way I'll have a look into it.

Ok, modified it so you can add files one by one, and removing files from the newly added list works properly now.

https://github.com/microcosm-cc/microweb/pull/304

My post has one attachment, I want to edit the post to remove the attachment. Hit the X, get the dialogue, hit OK, hit save changes, attachment is still there.

1 Attachment

Yep, can confirm this was an issue. Modified in PR above.

When should I expect that to start working?

When @Velocio merges the code and deploys it.

Uh-oh... I've been summoned.

Oh yes... another PR. I'll merge and shall do the SSH dance.

Merged and cache purged.

.

I may have a cached version... but I'm not convinced... feels more broke.

It appeared to work, then threw an error and there were no attachments 🤷‍♀️

Oh man. Found one more issue, albeit obscure. Sorry you have to double up again.
I think I'll have to step away after this one, lest I start re-writing too much stuff.

https://github.com/microcosm-cc/microweb/pull/305

Broke how?

Merged and purged.

Am heading into a meeting so I hope it works.

My test (not yet working):

1. New post
   
2. Add file 1
   
3. Add file 2
   
4. Remove file 1
   
5. Add file 3
   
6. Submit
   
   
   

Expectation: New post with files 2 and 3.

Reality: This breaks.

What test are you doing?

On FF mobile now

2 Attachments

Worked as expected on above reply