Subtle changes, bugs and feedback

Yup. I've followed the 'wanted' sub forum and all new items turn up in following but aren't marked as new. However, if I click through into wanted then the same thread is now marked as new.

Why do my embedded twitter photos never show up in the forum?

Why do my embedded twitter photos never show up in the forum?

This is something I can fix... give me an example and I'll set to work.

Fixed the followed forum does not mark as "NEW" bug.

Turned out that the updates for followed forum marked the forum as id = 0 which would lead to a COALESCE not triggering the NULL condition. I've simplified this by removing the extra columns, removing some JOINs and simply calling has_unread on the item itself.

It was, in essence, an old optimisation that was no longer needed.

On "following" performance.

I think it's about as fast as it is going to get.

Where it is slow is entirely down to old notifications as these are never pruned and if you've been following both of the Classifieds forums you could actually have thousands or tens of thousands of notifications.

What I could do is to add a "deleted notifications" thing.

This would only remove your old notifications, not affecting the things you are following... so you'd continue to get new notifications. But it would make the page load in milliseconds.

As an example, @hamrack today the following query takes 1.4 seconds, if I deleted just the notifications for "new items created in a forum you are following", the query would take 198 milliseconds.

Actually, I could cron a task to prune "new items created in a forum" that are older than 1 month.

Either you've interacted with them by then and you care about that stuff (which creates it's own notifications)... or you don't care and I prune the old notifications.

^ I'm doing that.

Makes a HUGE difference.

Done.

It will now be faster, always.

Fair enough, seems reasonable. I have taken to doing 'mark all as read' more frequently (I didn't realise it existed...) so that will help.

Zooooooooooom!

Yeah, quite the difference :)

Bit lost with what gets pruned and what doesn't.. Would threads that I'm following that have last been updated say 6 weeks ago, still show as "new" in my following page?

A few threads I more or less keep up with, but there are lots I'm interested in that I like to go back and catch up on when I have time (not necessarily within a month)

https://www.lfgss.com/comments/13659386/

On your notifications settings page: https://www.lfgss.com/updates/settings/

• When a comment has been posted in an item you are watching
  
• When a comment of yours is replied to
  
• When you are @mentioned in a comment
  
• When you receive a new comment in a private message
  
• When an attendee added to an event you are watching
  
• When a vote is cast in a poll you are watching
  
• When an event you are attending is imminent
  
• When a new item is created in a microcosm you are watching
  
• When a new user is created (new sign-in from unrecognised email) and you are watching the People page
  
  

Only notifications about that one bolded and italicised item will be pruned.

Which means; if you follow a whole forum and you get notifications about new conversations and events in that forum... those will get pruned after 1 month.

But... if during that month you commented on a conversation, replied to someone else, followed the conversation... those never get pruned.

I see your embedded photo.

Do you have an adblock privacy thing set so aggressively that it blocks photos from Twitter?

I can see it in twitter. Perhaps some kind of 3rd-party blocking. Except disabling NoScript and my adblocker don't make any difference. Maybe a Firefox config option I've messed with and don't recall. I'll investigate. Bike to pack first.

Ah, cool. I don't subscribe to any forums.

The outlining of the comments and view counter is a little off:

https://www.lfgss.com/microcosms/513/

Due to the eight figure view count possibly? LFGSS is getting too popular for its code!

Windows 10, Chrome version 58.0.3029.110 (64-bit).

Also broken on Safari 10.1.1
Beware Pornhub, Bike porn thread is getting more popular

1 Attachment

Damn.

Hmm.

So... it looks like I'll have to get rid of numbers and replace them with something else beyond some point.

i.e.

• < 1,000 = show precise numbers
  
• 1,000 >= 999,999 = {n}k, i.e. 87,986 = 87k
  
• > 1,000,000 = {n}m, i.e. 87,986,342 = 87m
  

A bit like the numbers on this forum: https://talk.turtlerockstudios.com/top

A bit like the numbers on this forum: talk.turtlerockstudios.com/top

Sounds like a good idea, YouTube also does it (on their app). And then maybe when you hover over it, you get the real number. Like with the time of posts:

By the way: why are links not clickable if they're quoted? Like above.

Good idea on putting the precise number in the hover text.

And the links aren't quotable because the markdown library doesn't do block parsing.

Although I'm curious:

A bit like the numbers on this forum: https://talk.turtlerockstudios.com/top

OK... I may put the https:// bit back onto links. It was originally removed to make text more readable, but I've got a second text parser running that would linkify the URL in a pre-processor stage if it has the protocol on it.

.