You are reading a single comment by @Velocio and its replies. Click here to read the full conversation.
  • I've noticed this a couple of times since the new auth; if you have an access_token cookie set, but the token is invalid/expired, and you go to https://www.lfgss.com/updates/, you get a 500 error.

    You'll probably see it in the logs. Obviously not a major issue, but I thought I'd mention it.

  • Oh, I am aware.

    But the error handling around it is very weird, and it's Django, and I'm not a total wiz at Python.

    After fixing all of the auth stuff on all sites I'm going to re-write the whole of the front-end to work on a Go server so that I basically understand it better and can fix things like that quickly.

    I know that seems backwards (doing auth stuff before web stuff) but that is due to Persona being switched off very soon and driving a hard deadline.

    I know it looks also like a sledgehammer to fix a small issue but actually there are lots of issues with the Django site of which this is one, and the sheer number of small issues combined with the unsupportable old version we're using means it's a lot safer and saner to make a bigger investment in a rewrite to something far more proven for us (and Go on the API has been flawless and required virtually no maintenance in 2 years whilst also having had major features added without causing headaches).

    So yeah, I know... but can't fix at the mo', and won't fix in the future as I'll just replace instead.

About

Avatar for Velocio @Velocio started