Subtle changes, bugs and feedback

Posted on
Page
of 312
  • Yeah, but I don't think I've disabled it or shortened it. Just need to make sure it's definitely actually delayed enough not to be confused.

  • Chrome 51.0.2704.81 on Android 6.0.1

    Although it's been like this for ages

  • Yep, I think I raised this a while ago. On mobile the buttons at the top of the reply edit box all fire with a drag / scroll event as well as a proper click.

    It is annoying.

  • On mobile the buttons at the top of the reply edit box all fire with a drag / scroll event as well as a proper click

    That, was the clue... Mobile only. It's a touch event.

    Try now.

    I think I've fixed it.

  • And the fix for this one... the JS included this:

    			var preferredUserEvent = 'click';
    			if ('ontouchstart' in window){
    				preferredUserEvent = 'touchstart';
    			}
    
    			var events = [
    				[preferredUserEvent,	'.wmd-bold',	buttons.bold,	'bold'],
    				[preferredUserEvent,	'.wmd-italic',	buttons.italic,	'italic'],
    				[preferredUserEvent,	'.wmd-quote',	buttons.quote,	'quote'],
    				[preferredUserEvent,	'.wmd-code',	buttons.code,	'code'],
    				[preferredUserEvent,	'.wmd-link',	buttons.link,	'link'],
    				[preferredUserEvent,	'.wmd-image',	buttons.image,	'image'],
    				[preferredUserEvent,	'.wmd-ol',	buttons.olist,	'olist'],
    				[preferredUserEvent,	'.wmd-ul',	buttons.ulist,	'ulist']
    			];
    

    So I've just commented out the bit about preferring ontouchstart. Can't imagine anyone preferring that.

  • Quoting seems to work properly now by the way on my machine (OS X 10.11.6 w/ Chrome 51.0.2704.106 (64-bit)).

  • You have, this has annoyed me for ages, thank you.

  • If it makes certain things unresponsive then touchend should provide the speed without too much of the unintended firing.
    What I usually do is to do as you have there and use a variable to set it to touchend for mobile, then if I do want the actual click event with its delay, just use 'click' as a string for that particular instance.

  • What I usually do is to do as you have there

    I didn't do that.

    Brilliant JS guy did it, leaving me with lots of obscure bugs to unpick.

    I prefer vanilla, simple, clear JS if I ever have to touch JS.

    I'm not even convinced of the need for jQuery let alone the plugins for it that we have on this site.

    About the only thing I think fair enough to... is the Markdown editor and preview, but given the preview is a bit shit I think that would be improved by just going to the server and asking for a quick render.

  • @Velocio

    tried to tag @Donut! (this one https://www.lfgss.com/profiles/49837/ ) using the drop down menu as you type in a members name, but it defaults to the other exclamation less @Donut, as it makes the exclamation mark black rather than a hyperlink.

    Any thoughts on why that is happening? As I'm selecting the right one..

    Many thanks

  • Special characters... as in the !

    The matching system for + and @ mentions uses the same convention as Twitter and Google Plus, which means it matches on alphanumeric usernames only.

    Hence it does not work for special characters.

  • so ! means that any mention of @Donut!, automatically defaults to @Donut.

    so what about @b&d and @>>>>>> does that mean that whenever I @ them, they never get an alert? But how can I send them pm's?

  • Yes and yes.

    And visit their profile and hit "Send Message" and it will populate the user as the To recipient via their profile id.

    Though @47910 doesn't have quite the same ring to it.

  • What I could do is put an alert on the "Edit profile" page to warn when a username would not be @able .

    But... lots of people know this, and explicitly chose their name in order to not be @mentioned.

  • That, was the clue... Mobile only. It's a touch event.

    Try now.

    I think I've fixed it.

    Two of my biggest LFGSS annoyances fixed within a week.

    You, sir, are on a roll.

    "I'm on a good mixture, I don't want to waste it."

    Thanks

  • Quick question:

    If a thread (albeit relevant) has been dormant for several years is it best practice to resurrect or create a new one? @Velocio

    Thanks

  • If it's still applicable... resurrect it.

    No point having 20 threads on the same topic, that makes search useless.

  • Great - thanks for the lightning reply.

  • Just a thought, could we have the quote button pull the text down from the comment it's in reply to instead of the lines starting with etc?
    It will be some way to having a simple quote feature like there used to be. When not in reply to a comment, ie a new comment at the bottom of the thread it could still say lines starting with a greater than etc
    I haven't read through this thread so apologies if you've already discussed a quote feature

  • Just a thought, could we have the quote button pull the text down from the comment it's in reply to instead of the lines starting with etc?

    Select the text you want to quote, and then press the quote button.

  • Doesn't work on mobile though :( at least not on iOS

  • Doesn't work on mobile though :( at least not on iOS

    Get an android then :P

  • Or even a Windows phone. It works on WP8 and WP10

  • No, I think he is talking about the quote button above the text editor box, not the reply link.

    I don't see the point as:

    a) if you haven't selected any text then what would it quote?

    b) if you have selected he text you wish to quote, then you are right next to the reply link anyway.

  • Post a reply
    • Bold
    • Italics
    • Link
    • Image
    • List
    • Quote
    • code
    • Preview
About

Subtle changes, bugs and feedback

Posted by Avatar for Velocio @Velocio

Actions