Subtle changes, bugs and feedback

<ctrl+<c>(your mum)

<ctrl>+<v>(your mum)

<ctrl>+<b>(your)

I pasted your mum yesterday actually.

And tonight I shall cut yours

Its been highlighted that the list on the Locks That Work thread is no longer there ......I didn't even know this.

But important locks were listed there, that have been deleted - like the Abus Granit Extreme.

Was this list saved anywhere, or just casually discarded?

The list is there, it's the first post: https://www.lfgss.com/conversations/144109/

What am I not seeing?

After the migration to Microcosm, and specifically the change in format from BBCode to Markdown, the list that was there was broken... really badly formatted and unreadable.

So I re-formatted it from BBCode to Markdown. Just literally took out asterixes that were additional formatting and tidied up indentation so that it displayed as numbered or bullet lists as appropriate. There were also lots of line breaks in the wrong place, and attempts to do numbered lists where the numbers are repeated... all of which Markdown treats differently from BBCode and caused the layout to fundamentally break (to the degree that the first post was actually unreadable).

The system keeps the original list, but it will not render it properly because there were an enormous number of asterixes (the BBCode for bold, italic and underline gets converted to the Markdown equivalent and sections like this broke the formatting in fundamental ways: [ B ][ U ][ I ]18mm[/ I ][/ U ] Kryptonite New York[/ B ] [ B ]M-18 [/ B ][tied with], it even thinks that tied with is an unmatched BBCode tag and that line looks like this to Markdown: ****18mm** Kryptonite New York** **M-18**) and brackets mismatched around links (where the bracketed comment butted onto the link), etc. I'll pull a copy and manually compare to see whether the format script I ran over it dropped anything. I used about 20 regular expressions to tidy it up given the length of it and the mess it was in, it's possible that one of those dropped something, but I have the old version to compare with so I'll manually check it.

OK, having pulled up the original imported version.

Abus Granite 59 line was copied twice, and had really bad formatting and appears to have been stripped in both places.

Pinhead had bad formatting and was stripped from the first place it appeared, but the second instance wasn't a copy of the first, was parseable and survived.

The demoted section which contained the Trelock had bad formatting and appears to have been stripped in it's entirety.

A few duplicate end of line links that offered two of three places to get something from appear to have been dropped as formatting errors, and also appear to be surplus anyway.

I'll restore the 2 mentions of the Abus, the 1 mention of Pinhead, and the demoted section.

Everything else is intact, correct and present.

Not sure what formatting error caused the Abus to get dropped, but the fault with the Pinhead line was mismatched URLs:

**Pinhead ** [http://www.cycle-route.com/bikeshop/2103-Pinhead-Duo-Pack-Locking-Skewer-Set.html](http://www.pinheadlocks.com/index.php?page=shop.product_details&flypage=flypage.tpl&product_id=38&category_id=10&option=com_virtuemart&Itemid=60&lang=en)

The actual destination leads to a 404, so I'm just using the cycle-route link which still works.

It also appears that the attachments that are not images are not being linked properly at the bottom.

Tidied up the attachments area such that:

• Attachments are identified by a horizontal rule
  
• Non-image attachments are listed before images
  
• If there are 5 or fewer images they are shown inline
  
• If there are greater than 5 images, they are shown as thubnails with links to the images
  

Even with only one attachment I'm getting photos as thumbnails on Android Chrome

I'm really hoping for velocio's sake all these tidy ups only take a few minutes.

Are you?

Interesting.

Let me see.

1 Attachment

Oh yeah.

Does the page move to the left for anyone else on their phones?

This would be my quoting a single line of code above which is too wide for the screen.

Standard HTML fun, confuses some browsers though.

Fixed that.

Found another bug... we only show the first 25 attachments, regardless of how many attachments there are.

To some extent I'm fine with that, and to paginate attachments would be a really confusing interface.

Awesome

OK, so out of more than 6 million comments, only 30 comments have more than 25 attachments.

I'm not going to fix this... I'm going to limit the system to only show the first 25 and people who need more can put them on different comments.

For example, the list of messenger / courier bags https://www.lfgss.com/conversations/138428/ (also virtually unreadable in the new formatting) has 118 attachments on the first post.

In fact, 24 of the 30 comments that have more than 25 attachments are "lists" of things. The other 6 are For Sale threads in which people are listing every damn thing in the world for sale.

I'll put the limit in place.

@GA2G , of the 43k+ people on the platform, you are the most affected by this. You're also the most affected by formatting changes as most of the lists are now unreadable. Compare the linked messenger bag list with the newly formatted locks list. Locks is way more readable, the messenger bag list to most people is just a page of noise.

Oh, and this hasn't deleted the attachments, if there is greater than 25 they just won't be shown in the UI.

If you have a comment identifier, then it is possible to see the attachment info using the API:
https://lfgss.microcosm.app/api/v1/comments/6222673/attachments
https://lfgss.microcosm.app/api/v1/comments/6222673/attachments?offset=25
https://lfgss.microcosm.app/api/v1/comments/6222673/attachments?offset=50
https://lfgss.microcosm.app/api/v1/comments/6222673/attachments?offset=75
https://lfgss.microcosm.app/api/v1/comments/6222673/attachments?offset=100

Because we are already paginating comments within a conversation, to add another pagination control (potentially up to 25 for each comment on a conversation page) would be madness and cause a lot of confusion.

I may, at a later date, consider making the "25 attachments" thing a hyperlink to open a window to navigate the attachments... but I wouldn't hold your breath on it.

Could there be a bit of info added to the "Upload a file" link so that people know the basics?
(max 3MB, up to 5 attachments shown in-line, >5 attachments shown as thumbnails) or maybe too wordy. But would help (esp new people in Classifieds) know what to expect their posts to look like.

I've added the bit about 25 files total to the "upload a file" area.

I've added a bit about "If you upload more than 5 files we will display all attachments as thumbnails" to the formatting help section.

It is too wordy to go in the box for every comment considering 99% of comments do not have attachments.

on some threads i am being taken back to posts i have seen previously, rather than the oldest unread one

has something changed?