You are reading a single comment by @gbj_tester and its replies.
Click here to read the full conversation.
-
attachments/([0-9])+d[0-9]+-.$
attachments/([0-9]+)d[0-9]+-.$Rather you than me, regex hurts my brain.
Now I just have to find all the posts where I inlined the attachments and remove the duplication, although I still preferred the old distinction between inline images (main point of a post) and thumbnailed attachments (supplementary images for people wanting extra detail). Rolling your own thumbnails is a PITA now because
[url =foo][img ]bar[/img][/url]doesn't get parsed properly, and neither does "wysiwig" markdown, as @TinaKino discovered the other day, so making an image link to a url requires a bit of tiresome hacking.
gbj_tester
The issue of weird images being shown in some posts has now been resolved.
By and large, you were the person whose posts were most affected. Most people who attached images did not also embed them as an image within the post (they left the thumbnails at the bottom), but quite often you would insert the full image as an inline image in addition to the thumbnail.
There was a bug, but others wouldn't notice as much (attachments directly stuck on things work fine).
The bug was that for a given URL:
http://www.lfgss.com/attachments/47812d1326332953-vumachrono_ring_v2.pngWe parsed that using this regex:
attachments/([0-9])+d[0-9]+-.*$Which should have returned the value:
47812But... there is one character out of place in the regex and so we got:
4And instead of embedding the image you wanted, we redirected to whatever attachment #4 on vBulletin was.
The fix:
attachments/([0-9]+)d[0-9]+-.*$Which now correctly resolves vBulletin attachment URLs.
The images will still be duplicated within the post... once within the post content, and then we show the attachment too.