You are reading a single comment by @gbj_tester and its replies. Click here to read the full conversation.
  • That's freaking bizarre.

    I have no idea where those extra images are coming from... I'm going to go code spelunking to figure it out.

  • The issue of weird images being shown in some posts has now been resolved.

    By and large, you were the person whose posts were most affected. Most people who attached images did not also embed them as an image within the post (they left the thumbnails at the bottom), but quite often you would insert the full image as an inline image in addition to the thumbnail.

    There was a bug, but others wouldn't notice as much (attachments directly stuck on things work fine).

    The bug was that for a given URL:
    http://www.lfgss.com/attachments/47812d1326332953-vumachrono_ring_v2.png

    We parsed that using this regex:
    attachments/([0-9])+d[0-9]+-.*$

    Which should have returned the value:
    47812

    But... there is one character out of place in the regex and so we got:
    4

    And instead of embedding the image you wanted, we redirected to whatever attachment #4 on vBulletin was.

    The fix:
    attachments/([0-9]+)d[0-9]+-.*$

    Which now correctly resolves vBulletin attachment URLs.

    The images will still be duplicated within the post... once within the post content, and then we show the attachment too.

About

Avatar for gbj_tester @gbj_tester started